[PATCH v2 04/10] doc/bindings: Update PCIe devicetree binding documentation for LS2080A

[Lian M.H.]

Hi Bhupesh

I agree with Leo whose suggestion is a better.

Thanks,
Minghuan 

> -----Original Message-----
> From: Sharma Bhupesh-B45370
> Sent: Saturday, September 05, 2015 4:20 AM
> To: Leo Li <pku.leo at gmail.com>; Lian Minghuan-B31939
> <Minghuan.Lian at freescale.com>
> Cc: Arnd Bergmann <arnd at arndb.de>; Mark Rutland
> <mark.rutland at arm.com>; linux-arm-kernel at lists.infradead.org;
> marc.zyngier at arm.com; linux-clk at vger.kernel.org;
> Catalin.Marinas at arm.com; will.deacon at arm.com; olof at lixom.net; Bhupesh
> SHARMA <bhupesh.linux at gmail.com>; devicetree at vger.kernel.org
> Subject: RE: [PATCH v2 04/10] doc/bindings: Update PCIe devicetree binding
> documentation for LS2080A
> 
> > From: Leo Li [mailto:pku.leo at gmail.com]
> > Sent: Friday, September 04, 2015 11:27 PM On Fri, Sep 4, 2015 at 1:57
> > AM, Bhupesh Sharma <bhupesh.sharma at freescale.com> wrote:
> > > Add the documentation for compatible string "fsl,ls2080a-pcie"
> > > for Freescale's LS2080A platform.
> > >
> > > Signed-off-by: Minghuan Lian <Minghuan.Lian at freescale.com>
> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma at freescale.com>
> > > ---
> > >  .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > index 6286f04..e72e68f 100644
> > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis
> > > Designware PCIe IP  and thus inherits all the common properties
> > > defined
> > in designware-pcie.txt.
> > >
> > >  Required properties:
> > > -- compatible: should contain the platform identifier such as
> > "fsl,ls1021a-pcie"
> > > +- compatible: should contain the platform identifier such as
> > > +"fsl,ls1021a-pcie",
> > > +  "fsl,ls2080a-pcie".
> >
> > Make it generic like "fsl,<chip>-pcie"
> 
> Minghuan, if you don't have an objection, I would like to address Leo's
> suggestion in v3 of this series as I think it is a valid one.
> 
> Please share your views.
> 
> Regards,
> Bhupesh