[PATCH] arm64/efi: do not assume DRAM base is aligned to 2 MB

Will Deacon will.deacon at arm.com
Thu Oct 29 07:57:55 PDT 2015


On Thu, Oct 29, 2015 at 03:07:25PM +0100, Ard Biesheuvel wrote:
> The current arm64 Image relocation code in the UEFI stub assumes that
> the dram_base argument it receives is always a multiple of 2 MB. In
> reality, it is simply the lowest start address of all RAM entries in
> the UEFI memory map, which means it could be any multiple of 4 KB.
> 
> Since the arm64 kernel Image needs to reside TEXT_OFFSET bytes beyond
> a 2 MB aligned base, or it will fail to boot, make sure we round dram_base
> to 2 MB before using it to calculate the relocation address.
> 
> Reported-by: Timur Tabi <timur at codeaurora.org>
> Acked-by: Mark Rutland <mark.rutland at arm.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> 
> If deemed acceptable, could we either get this into v4.3 or tag it for
> stable (v4.3 only) please?

So is this fixing a regression introduced in 4.3? If so, can I have a
Fixes: tag too, please? (I was under the impression that this was a
longstanding issue, but the thread hasn't been easy to follow).

Will



More information about the linux-arm-kernel mailing list