[PATCH v11 6/8] arm64: renesas: add Salvator-X board support on DTS
geert at linux-m68k.org
Thu Oct 29 00:52:12 PDT 2015
On Fri, Oct 23, 2015 at 9:00 AM, Simon Horman <horms at verge.net.au> wrote:
> On Thu, Oct 15, 2015 at 12:01:40PM +0100, Mark Rutland wrote:
>> > + stdout-path = &scif2;
>> No rate? It would be better to be explicit here; you should be able to
>> stdout-path = "serial0:115200n8"
>> Where "115200n8" is replaced with whatever configuration this board
>> actually has.
> I think that we have had this discussion before in relation to
> a different board for a different Renesas SoC but I could be mistaken.
IIRC, at that time the code to parse the options wasn't upstream yet, so
adding the options would have broken the serial console.
I can confirm it works fine on Salvator-X with
stdout-path = "serial0:115200n8";
> The r8a7795 uses the sh-sci serial driver for which the default rate is
> 115200. It is hard for me to conceive of a situation where that would
> change without due consideration being given to the implications for DT
> Not specifying the baud here is consistent with what we have
> been doing for ARM32 Renesas SoCs for some time.
FWIW, I have updated all ARM32 Renesas DTSes locally:
1. Use alias in and add serial options to stdout-path,
2. Drop superfluous console= from bootargs (shmobile-legacy is gone,
and it works fine on boards with both fbdev and serial consoles).
And everything looks fine on the boards I could try it on (sh73a0/kzm9g,
r8a73a4/ape6evm, r8a7740/armadillo, r8a7791/koelsch).
Hence if you're open for this change, I can submit patches (or a single patch,
up to your preference).
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the linux-arm-kernel