typo in recent linux commit?
H. Nikolaus Schaller
hns at goldelico.com
Wed Oct 28 01:41:20 PDT 2015
Hi,
Am 28.10.2015 um 09:19 schrieb Efraim Yawitz <efraim.yawitz at gmail.com>:
> Hi,
>
> I was just browsing recent commits to the linux kernel tree, and I saw this in a change to arch/arm/vdso/vdsomunge.c:
>
> +#define swab32(x) \
> + ((((x) & 0x000000ff) << 24) | \
> + (((x) & 0x0000ff00) << 8) | \
> + (((x) & 0x00ff0000) >> 8) | \
> + (((x) & 0xff000000) << 24))
>
>
> Shouldn't that last '<<' be a '>>'?
>
> Ephraim Yawitz
Yes, you are right! Thanks for spotting this.
It appears that it was introduced during code simplification.
@maintainers: should I write another patch or can you more easily replace the original one?
BR,
Nikolaus Schaller
More information about the linux-arm-kernel
mailing list