[PATCH v2 1/4] ARM: dts: Add SROMc to Exynos 5410

Krzysztof Kozlowski k.kozlowski at samsung.com
Wed Oct 28 00:24:20 PDT 2015

On 28.10.2015 16:06, Pavel Fedin wrote:
>  Hello!
>>> +		sromc: sromc at 12250000 {
>>> +			compatible = "samsung,exynos-srom";
>>> +			reg = <0x12250000 0x10>;
>> Isn't 0x10 too small (SROM_BC3 won't be mapped)?
>  Muhaha, indeed, thanks for noticing this.
>  By the way, i've just checked exynos4.dtsi and exynos5.dtsi, they specify the same size. Did reviewers overlook this small thing?

Yep, I pointed that 0x100 (from first version of patchset) is too big...
but did not exactly check the length of new value.

> Shouldn't it be fixed then?

Yes. It hasn't been pulled yet by arm-soc... Let's wait Kukjin's opinion
how to deal with exynos[45].dtsi.

Best regards,

More information about the linux-arm-kernel mailing list