[PATCH] arm64: efi: make sure vmlinux load address aligned on 2MBytes

Ard Biesheuvel ard.biesheuvel at linaro.org
Tue Oct 27 19:11:33 PDT 2015


On 28 October 2015 at 11:10, Timur Tabi <timur at codeaurora.org> wrote:
> Ard Biesheuvel wrote:
>>
>> +               *image_addr = *reserve_addr = round_up(dram_base, SZ_2M) +
>> +                                                      TEXT_OFFSET);
>
>
> Shouldn't this be:
>
> *image_addr = *reserve_addr = round_up(dram_base + TEXT_OFFSET, SZ_2M);
>

No. I screwed up the patch since the trailing ) should not be there,
but we do need to round first, and only then add the offset.

-- 
Ard.



More information about the linux-arm-kernel mailing list