[PATCH 9/9] pinctrl: at91: add missing of_node_put

Linus Walleij linus.walleij at linaro.org
Tue Oct 27 09:18:02 PDT 2015


On Sat, Oct 24, 2015 at 4:42 PM, Julia Lawall <Julia.Lawall at lip6.fr> wrote:

> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
>
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>

Patch applied with Ludovic's ACK.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list