[PATCH v2] spi: Tegra: add device tree binding doc for SPI/QSPI

Stephen Warren swarren at wwwdotorg.org
Mon Oct 26 09:33:01 PDT 2015


On 10/23/2015 05:30 PM, Tom Warren wrote:
> This patch adds the device tree binding doc for the Tegra
> SPI/QSPI controllers on Tegra114 and Tegra210.

> diff --git a/doc/device-tree-bindings/spi/spi-tegra.txt b/doc/device-tree-bindings/spi/spi-tegra.txt

Since this is a patch to the Linux kernel, it should use the path and 
file names from the Linux kernel, so that should be:

Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt

(or perhaps an earlier SoC number if this HW block first appeared before 
Tegra210)

> +NVIDIA Tegra SPI/QSPI controller.

There's already a binding document for the regular SPI controller. The 
plain SPI entries should be removed from this file, leaving it covering 
the QSPI controller only.

Can you confirm that there physically is a separate QSPI controller in 
HW and that it has different registers to the regular SPI controller? 
Or, is QSPI simply a new mode of operation for the existing HW?

> +Required properties:
> +- compatible : should be one of the following:
> +  "nvidia,tegra114-spi" (for Tegra114)
> +  "nvidia,tegra210-qspi" (for Tegra210)
> +- reg: Should contain SPI registers location and length.
> +- interrupts: Should contain SPI interrupts.

Are there multiple interrupts or just one? I imagine just one, in which 
case just "interrupt" at the end of that description.



More information about the linux-arm-kernel mailing list