[PATCH 09/13] clk: versatile-icst: add device tree support

Linus Walleij linus.walleij at linaro.org
Mon Oct 26 06:14:15 PDT 2015


On Thu, Oct 15, 2015 at 9:26 PM, Stephen Boyd <sboyd at codeaurora.org> wrote:
> On 10/15, Linus Walleij wrote:
>> +
>> +     if (of_device_is_compatible(np, "arm,syscon-icst525"))
>> +             icst_desc.params = &icst525_params;
>> +     else if (of_device_is_compatible(np, "arm,syscon-icst307"))
>> +             icst_desc.params = &icst307_params;
>
> I guess if we add anymore here we should use an of_device_id
> array instead.

As it happens those two are gonna be it.

ARM never created any more integrated ICST devices, and
they stopped using them since. Those two are the required
ones.

(Fixing all other comments.)

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list