[PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()"

Dave P Martin Dave.Martin at arm.com
Fri Oct 23 06:34:04 PDT 2015

On Fri, Oct 23, 2015 at 07:35:06AM -0500, Timur Tabi wrote:
> Dave Martin wrote:
> >>>The commit 71a5cd8a4 makes the console hang for some times.
> >>>This reverts commit 71a5cd8a4a2602a6e9010b557a23af0a54df87b6.
> >What hangs?  Input?  Output?  Both?
> >
> >Is CREAD set on the terminal?  If only input hangs, it's possible CREAD
> >is not set and we were previously getting away with it, though I can't
> >easily see why it should be unset...
> Dave is right, the revert doesn't make any sense. Huang has a
> user-space bug.  Please check to see if CREAD is set.  I'm pretty
> sure it isn't.

Well, I'm not saying there's definitely no kernel bug, but I can't see
how the patch should cause it.  It may be triggering a latent bug
somewhere else in the driver than hasn't been biting us before, however.

!CREAD is the most obvious cause, so that should definitely be ruled
out first.  If CREAD is clear, we need to figure out why...


More information about the linux-arm-kernel mailing list