[PATCH] serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()

Linus Walleij linus.walleij at linaro.org
Fri Oct 23 03:04:48 PDT 2015


On Wed, Oct 7, 2015 at 10:27 PM, Timur Tabi <timur at codeaurora.org> wrote:

> The UART_DUMMY_DR_RX status bit is equal to (1 << 16), so a u16 is too small
> to hold that value.  The result is that UART_DUMMY_DR_RX is never passed
> to uart_insert_char().  This means that we're always accepting characters,
> even when CREAD (in termios) is not set.
>
> Signed-off-by: Timur Tabi <timur at codeaurora.org>

Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list