[PATCH 2/4] cpufreq: imx6q: Fix wrong device in devm_kzalloc
Viresh Kumar
viresh.kumar at linaro.org
Thu Oct 22 06:29:01 PDT 2015
On 22-10-15, 10:47, Sascha Hauer wrote:
> devm_kzalloc must be called with the device that is actually probed,
> not with cpu_dev which resources are not freed when probe fails.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index fabd144..7557d1e 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -260,7 +260,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
> }
>
> /* Make imx6_soc_volt array's size same as arm opp number */
> - imx6_soc_volt = devm_kzalloc(cpu_dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL);
> + imx6_soc_volt = devm_kzalloc(&pdev->dev,
> + sizeof(*imx6_soc_volt) * num, GFP_KERNEL);
Please rewrite it as:
imx6_soc_volt = devm_kzalloc(&pdev->dev,
sizeof(*imx6_soc_volt) * num, GFP_KERNEL);
checkpatch --strict will warn against this.
--
viresh
More information about the linux-arm-kernel
mailing list