[PATCH] cpufreq: imx6: rework getting clocks and regulators

[Heiner Kallweit]

On Tue, Oct 20, 2015 at 3:17 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> On Tue, Oct 20, 2015 at 02:56:51PM +0200, Heiner Kallweit wrote:
>> On Tue, Oct 20, 2015 at 2:47 PM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
>> > On Tue, Oct 20, 2015 at 02:26:58PM +0200, Lucas Stach wrote:
>> >> Am Dienstag, den 20.10.2015, 13:56 +0200 schrieb Sascha Hauer:
>> >> > Use devm_* functions for getting clocks and regulators. This simplfifies
>> >> > the error path. Also return the error from the failing call instead of
>> >> > collating all regulator and clock errors to -ENOENT. With this the
>> >> > driver can properly handle -EPROBE_DEFER. Handling deferred probing
>> >> > becomes necessary once the SoC internal regulators get supplies. While
>> >> > the SoC internal regulators are registered early in architecture code,
>> >> > the supplies may be regular I2C devices which may be probed after the
>> >> > cpufreq driver.
>> >> >
>> >> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
>> >>
>> >> NACK
>> >>
>> >> This has come up several times before, maybe we should get a comment in
>> >> the code.
>> >
>> > Indeed, yes. This would help not wasting developing time.
>> >
>> > Anyway, the driver needs to handle -EPROBE_DEFER properly, if not with
>> > devm_ then without it.
>> >
>> About two days ago I sent two patches fixing this. Meanwhile Viresh
>> accepted them
>> so they should show up in the next kernel very soon.
>
> Thanks for the hint, just found the patches in the archives.
> Unfortunately your patches do not work properly, but I'll reply to your
> patch.
>
I think the patches do what they're supposed to do: fix handling -EPROBE_DEFER.
However I agree that they're not sufficient to fix the other basic
problem you pointed out.
Therefore lets go with your approach.

> Sascha
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |