[PATCH] mutex: make mutex_lock_nested an inline function

Peter Zijlstra peterz at infradead.org
Wed Oct 14 01:37:07 PDT 2015


On Wed, Oct 14, 2015 at 10:20:50AM +0200, Peter Zijlstra wrote:
> > > On Tue, Oct 13, 2015 at 10:30:08PM +0200, Arnd Bergmann wrote:
> > > > The second argument of the mutex_lock_nested() helper is only
> > > > evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we
> > > > get this build warning for the new regulator_lock_supply
> > > > function:
> > > > 
> > > > drivers/regulator/core.c: In function 'regulator_lock_supply':
> > > > drivers/regulator/core.c:142:6: warning: unused variable 'i' [-Wunused-variable]
> > > > 
> > > > To avoid the warning, this patch changes the definition of
> > > > mutex_lock_nested() to be static inline function rather than
> > > > a macro, which tells gcc that the variable is potentially
> > > > used.
> 
> Uuh, I just looked at next and saw this regulator_lock_supply()
> function. How is that limited? subclass must be <8 otherwise bad things
> happen.

Also, the function appears unused, just delete it ;-)



More information about the linux-arm-kernel mailing list