[PATCH 0/3] delete unneeded of_node_put

Julia Lawall Julia.Lawall at lip6.fr
Mon Oct 12 13:43:13 PDT 2015


Device node iterators perform an of_node_put on each iteration, so putting
an of_node_put before going around to the next iteration results in a
double put.

The complete semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@r exists@
expression e1,e2;
local idexpression n;
iterator name for_each_node_by_name, for_each_node_by_type,
for_each_compatible_node, for_each_matching_node,
for_each_matching_node_and_match, for_each_child_of_node,
for_each_available_child_of_node, for_each_node_with_property;
iterator i;
position p1,p2;
statement S;
@@

(
(
for_each_node_by_name(n,e1) S
|
for_each_node_by_type(n,e1) S
|
for_each_compatible_node(n,e1,e2) S
|
for_each_matching_node(n,e1) S
|
for_each_matching_node_and_match(n,e1,e2) S
|
for_each_child_of_node(e1,n) S
|
for_each_available_child_of_node(e1,n) S
|
for_each_node_with_property(n,e1) S
)
&
i at p1(...) {
   ... when != of_node_get(n)
       when any
   of_node_put at p2(n);
   ... when any
}
)

@s exists@
local idexpression r.n;
statement S;
position r.p1,r.p2;
iterator i;
@@

 of_node_put at p2(n);
 ... when any
 i at p1(..., n, ...)
 S

@depends on s@
local idexpression n;
position r.p2;
@@

- of_node_put at p2(n);
// </smpl>

---

 arch/arm/mach-exynos/pm_domains.c                 |    8 +++-----
 drivers/soc/qcom/smd.c                            |    4 +---
 drivers/video/fbdev/omap2/dss/omapdss-boot-init.c |    4 +---
 3 files changed, 5 insertions(+), 11 deletions(-)



More information about the linux-arm-kernel mailing list