[PATCH v3] arm-soc: Add support for Sigma Designs Tango4

Måns Rullgård mans at mansr.com
Fri Oct 9 07:40:39 PDT 2015

Arnd Bergmann <arnd at arndb.de> writes:

> On Tuesday 06 October 2015 17:57:00 Marc Gonzalez wrote:
>> This patch adds support for Sigma Designs "Tango4" platform, which is
>> built around the ARM Cortex A9 MPCore (single and dual core SoCs).
>> Tango4 is not to be confused with Tango3, which was built around a
>> MIPS 74kf CPU.
>> Signed-off-by: Marc Gonzalez <marc_gonzalez at sigmadesigns.com>
>> ---
>> v3 changes: Updated clock tree DT (clk driver submitted)
> Looks all reasonable to me now. Can I get an Ack from Måns? It sounds
> like he is the original author of the port.

NAK.  The clock parts are a complete shambles (compare to the patch I
sent earlier today), and the rest has a bunch of pointless and
misleading changes compared to my code.  This version won't work
correctly even on the SMP8759 hardware I have, let alone on the older
members of the chip family.  My code does.

The reason I haven't posted my patches is that I'm still working them
(albeit slowly), and I don't yet consider the code fit for upstreaming.

I've tried to work nicely with Sigma on this, but that's proving
difficult.  The patches posted so far by Marc seem to me like nothing
but poor NIH rewrites of my code.

Måns Rullgård
mans at mansr.com

More information about the linux-arm-kernel mailing list