[PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

Arnd Bergmann arnd at arndb.de
Thu Oct 8 07:38:31 PDT 2015


On Thursday 08 October 2015 12:03:18 Krzysztof Hałasa wrote:
> Hi,
> 
> Arnd Bergmann <arnd at arndb.de> writes:
> 
> > With those two changes in place, we no longer need the fake
> > pci_sys_data/pci_bus structures for faking config space writes,
> > and the stack usage goes down as well.
> 
> >  arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------
> 
> I'm ATM unable to test this change, but will do that at some point.
> Meanwhile, I guess there is nothing I can say against this patch.
> Thanks.
> 
> Acked-by: Krzysztof Hałasa <khalasa at piap.pl>
> 

Thanks! I've queued it up in next/fixes-non-critical for linux-4.4
now, if you find something wrong later, we can revert or fix up.

There is no urgency for this one, especially since you still want to
test it, so no reason to put it in 4.3.

This was the last pre-2015 build warning for the ARM defconfigs
and allmodconfig, all remaining warnings are regressions or new
code, and I've submitted patches for those. Let's see if we can
get to a warning-free kernel build in 4.4.

	Arnd



More information about the linux-arm-kernel mailing list