[PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable
Maurizio Lombardi
mlombard at redhat.com
Wed Oct 7 06:28:35 PDT 2015
Hi,
On 10/07/2015 03:11 PM, Arnd Bergmann wrote:
> - memset(&npiv_tbl, 0, sizeof(npiv_tbl));
> - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl))
> + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL);
> + if (!npiv_tbl)
> goto done;
>
If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
Regards,
Maurizio Lombardi
More information about the linux-arm-kernel
mailing list