[PATCH] bridge/netfilter: avoid unused label warning
nikolay at cumulusnetworks.com
Tue Oct 6 12:28:29 PDT 2015
On 10/06/2015 09:22 PM, Arnd Bergmann wrote:
> With the ARM mini2440_defconfig, the bridge netfilter code gets
> built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6
> disabled, which leads to a harmless gcc warning:
> net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit':
> net/bridge/br_netfilter_hooks.c:792:2: warning: label 'drop' defined but not used [-Wunused-label]
> This gets rid of the warning by cleaning up the code to avoid
> the respective #ifdefs causing this problem, and replacing them
> with if(IS_ENABLED()) checks. I have verified that the resulting
> object code is unchanged, and an additional advantage is that
> we now get compile coverage of the unused functions in more
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> Fixes: dd302b59bde0 ("netfilter: bridge: don't leak skb in error paths")
I posted a fix for this a couple of days ago, but I like your approach better.
Since mine is not yet applied (I sent it to netfilter-devel only, wasn't sure which
jurisdiction this falls into exactly) we can drop it.
Just for reference my patch is here:
Pablo, could you please drop it ?
By the way this takes care of another warning about unused variable (nf_bridge), too.
Reviewed-by: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>
More information about the linux-arm-kernel