[PATCH] arm-soc: Add Sigma Designs Tango4 port
Måns Rullgård
mans at mansr.com
Fri Oct 2 09:55:13 PDT 2015
Mason <slash.tmp at free.fr> writes:
>>> + uart0 {
>>> + compatible = "ralink,rt2880-uart";
>>> + reg = <0x10700 0x100>;
>>> + clock-frequency = <7372800>;
>>> + reg-shift = <2>;
>>> +/* fifo-size = <16>; BROKEN */
>>
>> Either fix whatever is broken or drop that line.
>
> I can't leave TODO reminders in the platform Kconfig?
> Even as comments?
Never mind, I've sent a patch fixing the problem.
>>> + intc: intc at e000 {
>>> + compatible = "sigma,tango-intc";
>>
>> Why do you insist on using other names than the ones I've been using for
>> months? Just want to leave your own mark on the code?
>
> You're using "sigma,smp8640-intc".
> The SMP8640 is a Tango3 (MIPS-based) platform.
> It makes no sense to have references to Tango3 in tango4.dtsi
> Aside from the CPU difference, Tango3 and Tango4 have a lot in common though.
It's commonplace to refer to peripherals by the earliest (supported)
chip using them. This avoids naming conflicts if a future chip uses a
different component. Some bits are incompatible even between different
devices in the tango3 family.
--
Måns Rullgård
mans at mansr.com
More information about the linux-arm-kernel
mailing list