[PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
David Miller
davem at davemloft.net
Mon Nov 30 11:50:57 PST 2015
From: Salil Mehta <salil.mehta at huawei.com>
Date: Thu, 26 Nov 2015 07:14:06 +0000
> -#define ENABLE (0x1)
> -#define DISABLE (0x0)
> +#define ENABLE 0x1
> +#define DISABLE 0x0
Defining such common macros names for such incredibly simple boolean values
is asking for trouble, in particular it can possibly collide with other
defines in the global namespace.
Use "true", "false", and the "bool" type, because that is exactly how you
are using these values.
Thanks.
More information about the linux-arm-kernel
mailing list