[PATCH 00/13] mvneta Buffer Management and enhancements
davem at davemloft.net
Sun Nov 29 18:02:10 PST 2015
From: Marcin Wojtas <mw at semihalf.com>
Date: Sun, 29 Nov 2015 14:21:35 +0100
>> Looking at your patches, it was not entirely clear to me how the buffer
>> manager on these Marvell SoCs work, but other networking products have
>> something similar, like Broadcom's Cable Modem SoCs (BCM33xx) FPM, and
>> maybe Freescale's FMAN/DPAA seems to do something similar.
>> Does the buffer manager allocation work by giving you a reference/token
>> to a buffer as opposed to its address? If that is the case, it would be
>> good to design support for such hardware in a way that it can be used by
>> more drivers.
> It does not operate on a reference/token but buffer pointers (physical
> adresses). It's a ring and you cannot control which buffer will be
> taken at given moment.
He understands this, he's asking you to make an "abstraction".
FWIW, I know of at least one more chip that operates this way too and
the code I wrote for it, particularly the buffer management, took a
while to solidify. Common helpers for this kind of situation would
have helped me back when I wrote it.
More information about the linux-arm-kernel