[PATCH v2 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Nov 26 10:27:36 PST 2015
Dear Marcin Wojtas,
On Thu, 26 Nov 2015 19:08:09 +0100, Marcin Wojtas wrote:
> MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer
> allocation was mistakenly set as BIT(1). This commit fixes the assignment.
>
> Signed-off-by: Marcin Wojtas <mw at semihalf.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> Cc: <stable at vger.kernel.org> # v3.8+
> Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
> unit")
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What is the user-visible impact of this bug? Indeed, the code is wrong,
but things were working fine until now.
So I am not questioning that this patch should be merged, but only
questioning whether the stable tag is appropriate.
Same questions for your patch 3/6.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list