[PATCH] ARM: avoid SMP DT initialisation on UP-only capable systems
Russell King
rmk+kernel at arm.linux.org.uk
Wed Nov 25 02:43:02 PST 2015
arm_dt_init_cpu_maps() initialises the CPU possible map even when the
boot CPU indicates that it is not SMP capable. This can happen with
SoCs where the SoC may have a single UP-only CPU, or may have a pair of
SMP CPUs - and this is the only difference.
One solution is to increase the number of DT files by forcing peopl to
properly describe the hardware: this means all the iMX6DL DT files need
to be duplicated for iMX6S and a whole raft of updates to boot loaders
and the like.
Another solution is to decide that it is inappropriate to initialise the
cpu_possible map with anything but the boot CPU on non-SMP capable
systems. This is implemented by this patch.
The situation currently may provoke a warning on earlier kernels,
printed during SMP bringup where we attempt to bring CPU1 online inspite
of CPU0 being a UP-only CPU, and this only failing due to the lack of
SMP operations.
Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
---
arch/arm/kernel/devtree.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
index 65addcbf5b30..bd72ce91d7a2 100644
--- a/arch/arm/kernel/devtree.c
+++ b/arch/arm/kernel/devtree.c
@@ -170,15 +170,18 @@ void __init arm_dt_init_cpu_maps(void)
return;
}
- /*
- * Since the boot CPU node contains proper data, and all nodes have
- * a reg property, the DT CPU list can be considered valid and the
- * logical map created in smp_setup_processor_id() can be overridden
- */
- for (i = 0; i < cpuidx; i++) {
- set_cpu_possible(i, true);
- cpu_logical_map(i) = tmp_map[i];
- pr_debug("cpu logical map 0x%x\n", cpu_logical_map(i));
+ if (is_smp()) {
+ /*
+ * Since the boot CPU node contains proper data, and all
+ * nodes have a reg property, the DT CPU list can be
+ * considered valid and the logical map created in
+ * smp_setup_processor_id() can be overridden
+ */
+ for (i = 0; i < cpuidx; i++) {
+ set_cpu_possible(i, true);
+ cpu_logical_map(i) = tmp_map[i];
+ pr_debug("cpu logical map 0x%x\n", cpu_logical_map(i));
+ }
}
}
--
2.1.0
More information about the linux-arm-kernel
mailing list