VF610 broken by pinctrl: freescale: imx: allow mux_reg offset zero

Stefan Agner stefan at agner.ch
Tue Nov 24 19:08:27 PST 2015


On 2015-11-24 18:10, Andrew Lunn wrote:
>> Can you please try the following change to see if it fixes your problem?
>>
>> Shawn
>>
>> diff --git a/drivers/pinctrl/freescale/pinctrl-vf610.c b/drivers/pinctrl/freescale/pinctrl-vf610.c
>> index 37a037543d29..587d1ff6210e 100644
>> --- a/drivers/pinctrl/freescale/pinctrl-vf610.c
>> +++ b/drivers/pinctrl/freescale/pinctrl-vf610.c
>> @@ -299,7 +299,7 @@ static const struct pinctrl_pin_desc vf610_pinctrl_pads[] = {
>>  static struct imx_pinctrl_soc_info vf610_pinctrl_info = {
>>         .pins = vf610_pinctrl_pads,
>>         .npins = ARRAY_SIZE(vf610_pinctrl_pads),
>> -       .flags = SHARE_MUX_CONF_REG,
>> +       .flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
>>  };
>>
>>  static const struct of_device_id vf610_pinctrl_of_match[] = {
> 
> Hi Shawn
> 
> I tested it, and it does work.

Thanks for bringing this up and testing this. FWIW:

Acked-by: Stefan Agner <stefan at agner.ch>

--
Stefan



More information about the linux-arm-kernel mailing list