[PATCH] ARM:VDSO: use PTR_ERR_OR_ZERO for vma check

Nathan Lynch Nathan_Lynch at mentor.com
Tue Nov 24 13:52:46 PST 2015


On 11/24/2015 12:56 AM, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3 at visteon.com>
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Signed-off-by: Prasanna Karthik <mkarthi3 at visteon.com>
> ---
>  arch/arm/kernel/vdso.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index 54a5aea..994e971 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -224,7 +224,7 @@ static int install_vvar(struct mm_struct *mm, unsigned long addr)
>  				       VM_READ | VM_MAYREAD,
>  				       &vdso_data_mapping);
>  
> -	return IS_ERR(vma) ? PTR_ERR(vma) : 0;
> +	return PTR_ERR_OR_ZERO(vma);
>  }
>  

Thanks, I think this is fine, but I won't be able to properly process
this until next week.




More information about the linux-arm-kernel mailing list