VF610 broken by pinctrl: freescale: imx: allow mux_reg offset zero

Shawn Guo shawnguo at kernel.org
Mon Nov 23 21:41:28 PST 2015


On Mon, Nov 23, 2015 at 04:08:23PM +0100, Andrew Lunn wrote:
> > Can you please try the following change to see if it fixes your problem?
> > 
> > Shawn
> > 
> > diff --git a/drivers/pinctrl/freescale/pinctrl-vf610.c b/drivers/pinctrl/freescale/pinctrl-vf610.c
> > index 37a037543d29..587d1ff6210e 100644
> > --- a/drivers/pinctrl/freescale/pinctrl-vf610.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-vf610.c
> > @@ -299,7 +299,7 @@ static const struct pinctrl_pin_desc vf610_pinctrl_pads[] = {
> >  static struct imx_pinctrl_soc_info vf610_pinctrl_info = {
> >         .pins = vf610_pinctrl_pads,
> >         .npins = ARRAY_SIZE(vf610_pinctrl_pads),
> > -       .flags = SHARE_MUX_CONF_REG,
> > +       .flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
> >  };
> >  
> >  static const struct of_device_id vf610_pinctrl_of_match[] = {
> 
> Hi Shawn
> 
> I'm away from the hardware right now, but yes, that should fix it.

I would wait for your testing confirmation to send the formal patch.

Shawn



More information about the linux-arm-kernel mailing list