[PATCH v2] i2c: cadence: Move to sensible power management
soren.brinkmann at xilinx.com
Mon Nov 23 10:47:10 PST 2015
On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote:
> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta
> <shubhrajyoti.datta at gmail.com> wrote:
> > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann
> > <soren.brinkmann at xilinx.com> wrote:
> >> Hi Shubhrajyoti,
> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote:
> >>> Currently the clocks are enabled at probe and disabled at remove.
> >>> Which keeps the clocks enabled even if no transaction is going on.
> >>> This patch enables the clocks at the start of transfer and disables
> >>> after it.
> >>> Also adapts to runtime pm.
> >>> Remove xi2c->suspended and use pm runtime status instead.
> >>> converts dev pm to const to silence a checkpatch warning.
> >>> Signed-off-by: Shubhrajyoti Datta <shubhraj at xilinx.com>
> >> To me, this looks all good. Just one small concern below.
> > Thanks for the review.
> Soren ,
> Do are you ok with the change or do you want me to resend without the
> suspended flag change.
I'm always for removing code that is not needed. If things are tested
and well and work without throwing any warnings I'm OK with it.
More information about the linux-arm-kernel