[PATCH 2/4] mtd: nand: sunxi: add missing of_node_put

Chen-Yu Tsai wens at csie.org
Sun Nov 22 23:26:18 PST 2015


On Thu, Nov 19, 2015 at 6:04 AM, Julia Lawall <Julia.Lawall at lip6.fr> wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
>
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>

Acked-by: Chen-Yu Tsai <wens at csie.org>



More information about the linux-arm-kernel mailing list