[PATCH V2 2/2] ARM: dts: imx6q: add Novena board

Fabio Estevam festevam at gmail.com
Fri Nov 20 12:58:39 PST 2015


On Fri, Nov 20, 2015 at 6:46 PM, Marek Vasut <marex at denx.de> wrote:
> From: Sean Cross <xobs at kosagi.com>
>
> Novena is an open-hardware laptop/desktop/bare board.
>
> See http://www.kosagi.com/w/index.php?title=Novena_Main_Page
>
> Signed-off-by: Sean Cross <xobs at kosagi.com>
> Cc: Fabio Estevam <fabio.estevam at freescale.com>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Cc: Sean Cross <xobs at kosagi.com>
> Cc: Shawn Guo <shawnguo at kernel.org>

Looks good:
Reviewed-by: Fabio Estevam <fabio.estevam at freescale.com>

Two minor comments:

> +&fec {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_enet_novena>;
> +       phy-mode = "rgmii";
> +       phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> +       mac-address = [00 00 00 00 00 00];

This mac-address entry could be removed, right?

> +&ssi1 {
> +       fsl,mode = "i2s-slave";

Please remove this one. It is no longer used.



More information about the linux-arm-kernel mailing list