[PATCH 1/2] ARM: dts: imx6: Add support for Toradex Apalis SoM

[Fabio Estevam]

On Thu, Nov 19, 2015 at 2:59 PM, Joshua Clayton
<stillcompiling at gmail.com> wrote:
> On Thursday, November 19, 2015 03:12:05 PM Lucas Stach wrote:
>> > +
>> > +/* PAD Ctrl values for common settings */
>> > +/* (PAD_CTL_HYS | PAD_CTL_PUS_100K_UP | PAD_CTL_PUE | PAD_CTL_PKE | PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm) */
>> > +#define PAD_CTRL_HYS_PU 0x1b0b0
>> > +
>> > +/* (PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PKE | PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm) */
>> > +#define PAD_CTRL_HYS_PD 0x130b0
>> > +
>> > +/* (PAD_CTL_PUS_22K_UP | PAD_CTL_PUE | PAD_CTL_PKE | PAD_CTL_SPEED_LOW | PAD_CTL_DSE_80ohm) */
>> > +#define PAD_CTRL_PU_22k 0x0f058
>> > +
>> I don't particularly like those defines. Maybe just replace by the hex
>> values?
> Hold on. Lets not throw the baby out with the bathwater.
> These macros (or something similar) look much nicer than hex values that I
> have to look up in the imx6 user manual over and over.
>
> Seems like a genuine improvement to me,
> except that they should not be in the dts itself.
> Rather in arch/arm/boot/dts/imx6<num>-pinfunc.h, or another include file
>
> What do you think?

Seems like a good idea to me.