[PATCH v9 1/2] arm-soc: Import initial tango4 device tree

Måns Rullgård mans at mansr.com
Wed Nov 18 08:38:24 PST 2015


Marc Gonzalez <marc_gonzalez at sigmadesigns.com> writes:

> On 18/11/2015 17:05, Måns Rullgård wrote:
>
>> Marc Gonzalez wrote:
>> 
>>> +		clkgen: clkgen at 10000 {
>>> +			compatible = "sigma,tango4-clkgen";
>>> +			reg = <0x10000 0x40>;
>>> +			clocks = <&xtal>;
>>> +			clock-output-names = "cpuclk", "sysclk";
>>> +			#clock-cells = <1>;
>>> +		};
>> 
>> Would you please consider using my clock driver that matches the actual
>> hardware, supports all the clock outputs required for USB, SATA, etc,
>> and works on tango3 as well?
>
> I was hoping to take baby steps to work up to a fully-functional port.
> The first step (in my mind) is this submission: a minimal port which
> only requires the two "main" clocks.
>
> The next step will add to the minimal port by supporting as many
> peripherals as possible, as well as their required clocks.

But the code already exists.  Why start over?

> Would you agree to discuss the clkgen driver in a few weeks, when I can
> concentrate full-time on the subject? Working on other drivers will give
> me a better understanding of the required clocks.

Perhaps it's premature to be pushing this as anything more than an RFC
at this stage.

-- 
Måns Rullgård
mans at mansr.com



More information about the linux-arm-kernel mailing list