[PATCH] cpufreq: scpi: Add dependency on SCPI clk driver

Viresh Kumar viresh.kumar at linaro.org
Tue Nov 17 21:19:53 PST 2015


On 17-11-15, 18:14, Punit Agrawal wrote:
> The SCPI clk driver registers the virtual cpufreq device that kicks off
> initialisation of the SCPI cpufreq driver. Make the dependendency
> explicit in Kconfig.

That's not a dependency. Any other part of the kernel can add this
*virtual* cpufreq device to get it going.

But, we do have dependency the other way round. clk_get() will fail
for the cpufreq driver if SCPI-clk driver is missing and perhaps
that's what you need to mention in the changelog.

> Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
> Signed-off-by: Punit Agrawal <punit.agrawal at arm.com>
> Cc: Sudeep Holla <sudeep.holla at arm.com>
> Cc: Rafael J. Wysocki <rjw at rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar at linaro.org>
> ---
>  drivers/cpufreq/Kconfig.arm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1582c1c..dadfdd4 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
>  
>  config ARM_SCPI_CPUFREQ
>          tristate "SCPI based CPUfreq driver"
> -	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
> +	depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI

This looks fine.

-- 
viresh



More information about the linux-arm-kernel mailing list