[PATCH] USB: USB_OTG does not depend on PM

Felipe Balbi balbi at ti.com
Tue Nov 17 13:38:33 PST 2015


Hi,

Arnd Bergmann <arnd at arndb.de> writes:
> USB_OTG initially depended on USB_SUSPEND, which was later turned into
> PM_RUNTIME and finally into PM. I don't know at what point the dependency
> became unnecessary but it appears to work fine without CONFIG_PM now.
>
> However, we get lots of warnings in randconfig kernels like:
>
> warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM)
>
> whenever CONFIG_PM is disabled and something else selects USB_OTG.
> Let's just drop the dependency to avoid the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
> I keep seeing this one in my ARM randconfig test

and how did you test this ? Did you make sure you're not breaking HNP ?
For HNP to happen we depend on a bus_suspend and bus_suspend is only
available on CONFIG_PM, unless that has changed.

Seems like you've only compile tested this patch, is that correct ?

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151117/f383883d/attachment.sig>


More information about the linux-arm-kernel mailing list