[RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

Masahiro Yamada yamada.masahiro at socionext.com
Sun Nov 15 19:40:09 PST 2015

Hi Linus

2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.walleij at linaro.org>:
> On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada
> <yamada.masahiro at socionext.com> wrote:
>> The dependency "depends on RESET_CONTROLLER" is already met.
>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> NACK, this pin controller needs that as dependency, I don't worry
> that it's overspecified.
> They both do this:
> #include <linux/reset.h>
> And the object should specify its dependencies, not rely on them
> being implicitly available.
> The dep is there for human readers too, not just machines. And to
> them, this is helpful information.

How strict we should follow this rule?

Many drivers depend on OF, but do they all have "depends on OF"?

Best Regards
Masahiro Yamada

More information about the linux-arm-kernel mailing list