[PATCH] bpf_trace: Make dependent on PERF_EVENTS
davem at davemloft.net
Tue Nov 10 12:40:35 PST 2015
From: Steven Rostedt <rostedt at goodmis.org>
Date: Tue, 10 Nov 2015 15:28:17 -0500
> Arnd Bergmann reported:
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
> kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
> kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
> if (event->oncpu != smp_processor_id() ||
> kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
> This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
> is disabled. I'm not sure if that is a configuration we care
> about, otherwise we could prevent this case from occuring by
> adding Kconfig dependencies.
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv@wuerfel
> Reported-by: Arnd Bergmann <arnd at arndb.de>
> Signed-off-by: Steven Rostedt <rostedt at goodmis.org>
I'll apply this, thanks Steven et al.
More information about the linux-arm-kernel