[PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver

Andy Shevchenko andy.shevchenko at gmail.com
Sun Nov 8 14:00:32 PST 2015


On Sun, Nov 8, 2015 at 11:51 PM, Sinan Kaya <okaya at codeaurora.org> wrote:
>
>
> On 11/8/2015 3:47 PM, Andy Shevchenko wrote:
>>>
>>> +       trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> >+       if (!trca_resource) {
>>> >+               rc = -ENODEV;
>>> >+               goto bailout;
>>> >+       }
>>
>> Why did you ignore my comment about this block?
>> Remove that condition entirely.
>>
>>> >+
>>> >+       trca = devm_ioremap_resource(&pdev->dev, trca_resource);
>>> >+       if (IS_ERR(trca)) {
>>> >+               rc = -ENOMEM;
>>> >+               goto bailout;
>>> >+       }
>
>
> Sorry, I didn't quite get your comment. I thought you wanted to see
> platform_get_resource and devm_ioremap_resource together.
>
> Which one do you want me to remove?

At the end you would have something like

res = platform_get_resource();
addr = devm_ioremap_resources();
if (!addr) {
…
}

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-arm-kernel mailing list