[PATCH] dma: fix returnvar.cocci warnings
Andy Shevchenko
andy.shevchenko at gmail.com
Sun Nov 8 13:15:32 PST 2015
On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall <julia.lawall at lip6.fr> wrote:
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Sinan Kaya <okaya at codeaurora.org>
> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
Who is the author?
I suppose Fengguang is the reporter, right?
> ---
>
> hidma_ll.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/drivers/dma/qcom/hidma_ll.c
> +++ b/drivers/dma/qcom/hidma_ll.c
> @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev *
>
> static int hidma_ll_hw_start(struct hidma_lldev *lldev)
> {
> - int rc = 0;
> unsigned long irqflags;
>
> spin_lock_irqsave(&lldev->lock, irqflags);
> writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET);
> spin_unlock_irqrestore(&lldev->lock, irqflags);
>
> - return rc;
> + return 0;
> }
>
> bool hidma_ll_isenabled(struct hidma_lldev *lldev)
> @@ -600,7 +599,6 @@ bool hidma_ll_isenabled(struct hidma_lld
> int hidma_ll_queue_request(struct hidma_lldev *lldev, u32 tre_ch)
> {
> struct hidma_tre *tre;
> - int rc = 0;
> unsigned long flags;
>
> tre = &lldev->trepool[tre_ch];
> @@ -618,7 +616,7 @@ int hidma_ll_queue_request(struct hidma_
> lldev->tre_write_offset = (lldev->tre_write_offset + TRE_SIZE)
> % lldev->tre_ring_size;
> spin_unlock_irqrestore(&lldev->lock, flags);
> - return rc;
> + return 0;
> }
>
> int hidma_ll_start(struct hidma_lldev *lldev)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list