[PATCH v5 3/6] ftrace: allow arch-specific stack tracer

Steven Rostedt rostedt at goodmis.org
Fri Nov 6 05:39:45 PST 2015


On Fri,  6 Nov 2015 15:44:42 +0900
AKASHI Takahiro <takahiro.akashi at linaro.org> wrote:

> A stack frame may be used in a different way depending on cpu architecture.
> Thus it is not always appropriate to slurp the stack contents, as current
> check_stack() does, in order to calcurate a stack index (height) at a given
> function call. At least not on arm64.
> In addition, there is a possibility that we will mistakenly detect a stale
> stack frame which has not been overwritten.
> 
> This patch makes check_stack() a weak function so as to later implement
> arch-specific version.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>

Note, I already accepted this patch. I'll be pushing it to Linus today.

I also added a patch on top of it to rename max_stack_lock to
stack_trace_max_lock to stay consistent with the other global variables
used in this file. You may need to update your code to handle that.

-- Steve



More information about the linux-arm-kernel mailing list