[PATCH] staging: etnaviv: fix platform_no_drv_owner.cocci warnings

Arnd Bergmann arnd at arndb.de
Fri Nov 6 01:17:18 PST 2015

On Friday 06 November 2015 07:47:58 Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> CC: Christian Gmeiner <christian.gmeiner at gmail.com>
> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr>

Patch looks good of course.

It looks like the conversion is stagnating, probably as we seem to have some
unmaintained drivers, slow maintainers, or cases that
platform_no_drv_owner.cocci doesn't catch:

for i in v3.18 v3.19 v4.0 v4.1 v4.2 v4.3 next/master ; do
	echo $i `git grep -A15 -w platform_driver $i  | grep owner.*THIS_MODULE  | wc -l`

v3.18 1798
v3.19 112
v4.0 98
v4.1 94
v4.2 98
v4.3 80
next/master 85

(this includes some false positives)

Is there any way we can prevent new ones from creeping in after we remove
the remaining ones? A compile-time check would be best, but I can't think
of one as there are other subsystems that still set .owner. Maybe add a
WARN_ON to platform_driver_register() and add that to linux-next on top of
a patch (or series of patches) that removes the remaining ones?


More information about the linux-arm-kernel mailing list