[PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration
p.fedin at samsung.com
Fri Nov 6 00:14:49 PST 2015
> > +- samsung,srom-timing : array of 6 integers, specifying bank timings in the
> > + following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs.
> > + Each value is specified in cycles and has the following
> > + meaning and valid range:
> > + Tacp : Page mode access cycle at Page mode (0 - 15)
> > + Tcah : Address holding time after CSn (0 - 15)
> > + Tcoh : Chip selection hold on OEn (0 - 15)
> > + Tacc : Access cycle (0 - 32)
> All of the manuals have error here. Probably it can be either: 1-32 or
> 0-31. I would bet on 0-31, what do you think?
Damn, everything starts from 0, so i automatically put '0 - 32'. The actual time, however, varies from 1 to 32, but the value is
from 0 to 31, i. e. <time> - 1
What shall we do? Just document this, or adjust the code to take number of cycles and subtract 1? To tell the truth, i'm already
sick of these small fixups, and i would prefer just to fix documentation.
Samsung Electronics Research center Russia
More information about the linux-arm-kernel