[RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

Linus Walleij linus.walleij at linaro.org
Thu Nov 5 05:40:07 PST 2015


On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:

> ARCH_SUNXI selects RESET_CONTROLLER.
> The dependency "depends on RESET_CONTROLLER" is already met.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>

NACK, this pin controller needs that as dependency, I don't worry
that it's overspecified.

They both do this:
#include <linux/reset.h>

And the object should specify its dependencies, not rely on them
being implicitly available.

The dep is there for human readers too, not just machines. And to
them, this is helpful information.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list