[PATCH 10/11] tty: amba-pl011: add support for 32-bit register access
Timur Tabi
timur at codeaurora.org
Tue Nov 3 06:57:05 PST 2015
Russell King wrote:
> - return readw(uap->port.membase + pl011_reg_to_offset(uap, reg));
> + void __iomem *addr = uap->port.membase + pl011_reg_to_offset(uap, reg);
> +
> + return uap->access_32b ? readl(addr) : readw(addr);
Ok, ignore my previous email. I just noticed this.
This version is fine, except that it now performs a runtime check for
every I/O access. Isn't that too much overhead? access_32b will always
be either True or False for the life of the entire SOC.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
More information about the linux-arm-kernel
mailing list