[PATCH] ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK
Alexandre Belloni
alexandre.belloni at free-electrons.com
Sun Nov 1 15:45:20 PST 2015
Hi Marek,
On 02/11/2015 at 00:27:05 +0100, Marek Vasut wrote :
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
You probably don't need those three properties
> + main_clock: clock at 0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
> +
likewise, if you don't need to boot on older kernels, I'd suggest
removing clock at 0.
> +/ {
> + model = "DENX MA5D4EVK";
> + compatible = "denx,ma5d4evk", "atmel,sama5d4", "atmel,sama5";
> +
> + chosen {
> + bootargs = "ignore_loglevel earlyprintk";
I think you don't really want to enforce those options, especially
earlyprintk as it can lead to a crash if UART_PHYS is not set properly
(for example, I usually boot the same kernel on sama5d3 and sama5d4).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list