[PATCH 07/12] i2c: pxa: Reset i2c controller on timeout in interrupt and pio mode

Vaibhav Hiremath vaibhav.hiremath at linaro.org
Fri May 29 14:19:24 PDT 2015



On Saturday 30 May 2015 02:43 AM, Robert Jarzmik wrote:
> Vaibhav Hiremath <vaibhav.hiremath at linaro.org> writes:
>
>> In case of timeout during msg xfer assert reset to
>> i2c controller for both interrupt and PIO mode of operation.
>>
>> Signed-off-by: Jett.Zhou <jtzhou at marvell.com>
>> [vaibhav.hiremath at linaro.org: Split & merge patches into logical changes
>> and update the Changelog]
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath at linaro.org>
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath at linaro.org>
> I have the same comment as before.
> I don't like a reset in the transfer path, especially in normal busy phases for
> slow I2C devices. A quirk as before.
>

Note that this assertion of reset in in case of timeout error.

Timeout error may be due to various reasons, and this is recovery
mechanism.

Thanks,
Vaibhav



More information about the linux-arm-kernel mailing list