[PATCH v0] gpio: xgene: add ACPI support for APM X-Gene GPIO standby driver

[Mika Westerberg]

On Thu, May 28, 2015 at 01:46:28PM +0700, Y Vo wrote:
> +#ifdef CONFIG_ACPI
> +	if (priv->nirq > 0) {
> +		/* Register interrupt handlers for gpio signaled acpi events */
> +		acpi_gpiochip_request_interrupts(&priv->bgc.gc);
> +	}
> +#endif

You don't need to check CONFIG_ACPI as acpi_gpiochip_request_interrupts()
will be stubbed out if !CONFIG_ACPI.

Should you call acpi_gpiochip_free_interrupts() somewhere to unregister
the interrupts as well?

Even better if you can switch your driver to use GPIOLIB_IRQCHIP all
this is done automatically for you.