[PATCH v3 1/3] ahci: Move interrupt enablement code to separate functions

Tejun Heo tj at kernel.org
Wed May 27 11:09:20 PDT 2015


Hello,

On Wed, May 27, 2015 at 10:01:31AM +0200, Robert Richter wrote:
> +static int ahci_init_intx(struct pci_dev *pdev, unsigned int n_ports,
> +			struct ahci_host_priv *hpriv)
> +{
>  	pci_intx(pdev, 1);
> +
>  	return 0;
>  }

Let's please not factor out the above as a separate function.  An one
lin function which always returns 0 doesn't really serve any purpose.

Thanks.

-- 
tejun



More information about the linux-arm-kernel mailing list