[PATCH v10 4/5] edac: Add APM X-Gene SoC EDAC driver
bp at alien8.de
Fri May 22 01:46:25 PDT 2015
On Fri, May 22, 2015 at 10:23:11AM +0200, Arnd Bergmann wrote:
> > +static int edac_mc_idx;
> > +static int edac_mc_active_mask;
> > +static int edac_mc_registered_mask;
> > +static DEFINE_MUTEX(xgene_edac_mc_lock);
> It would also be best to avoid global variables, but it seems that at
> least the edac_mc_idx is needed to work with the EDAC subsystem.
> Maybe Boris has an idea for how to avoid it.
Right, so AFAICT this is used in
and basically we're supplying the memory controller numbers in the order
we're calling xgene_edac_mc_add(). Perhaps we need to make the memory
controller numbering explicit with DT...
ECO tip #101: Trim your mails when you reply.
More information about the linux-arm-kernel