[PATCH v2 0/7] Change snvs rtc and poweroff to use syscon add pwrkey driver

Zhi Li lznuaa at gmail.com
Wed May 20 08:03:46 PDT 2015


On Wed, May 20, 2015 at 9:46 AM, Joshua Clayton
<stillcompiling at gmail.com> wrote:
>>
>> +       snvs_np = of_get_parent(pdev->dev.of_node);
>> +       if (!snvs_np)
>> +               return -ENODEV;
>> +
>> +       data->snvs = syscon_node_to_regmap(snvs_np);
>> +       of_node_put(snvs_np);
>> +
>> +       if (!data->snvs) {
>> +               pr_err("Can't snvs syscon\n");
>> +               return -ENODEV;
>> +       }
>>
>> How about change error message to " Can't snvs syscon, probably use
>> old dts file"?
> How about simply: "Cannot find snvs syscon node in devicetree."

Shawn:
          Are you okay for that?

best regards
Frank Li

>
>
> --
> ~Joshua Clayton



More information about the linux-arm-kernel mailing list