[PATCH v3] serial: 8250_uniphier: add UniPhier serial driver
jslaby at suse.cz
Tue May 19 01:57:59 PDT 2015
On 05/19/2015, 10:54 AM, Masahiro Yamada wrote:
>>> +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */
>>> +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */
>>> +#define UNIPHIER_UART_LCR_SHIFT 8
>>> +#define UNIPHIER_UART_DLR 9 /* Divisor Latch Register */
>> Nit pick: Please fix identation. After "define" just put one blank.
>> I personally prefer that the define values are aligned by tabs, but
>> that's up tu you.
> I intentionally use deeper indentation for *_SHIFT
> because I want to clearly show UNIPHIER_UART_LCR_SHIFT
> belongs to UNIPHIER_UART_LCR_MCR register.
> I also want to describe them within 80 columns including comments,
> so I cannot insert extra TABs to align the values.
Hi, what about one space between # and define which is used sometimes?
More information about the linux-arm-kernel